Telemetry Source Before/After events feedback/thoughts

[avanderhoorn]

Currently there are a few places where we have various Before/After events - BeforeAction/AfterAction and BeforeActionMethod/AfterActionMethod being amongst them. In both of these cases the Before events has more details than the After event. This means that for people interested in getting that before data in conjunction with the timing data have to subscribe to both events and either independently store the data from the begin event and carry it though to the after, or correlate the data after the fact.

In most cases, if the After event had the same data as the Before event, it would simplify things for the developer with the only thing they would need to store/flow between the two events is the timing information. In our case, it would also mean that we would only need to publish the After event to our internal store and/or not have to store this subset of data independently whilst waiting for the post event if we only wanted the one event going through to our internal store.

For the current Before/After events where there is a difference in parameters that are published, it would seem that the extra data the Before event has could easily be made available to the After event as well. And moving forward it would seem this pattern would continue as the After usual is executed in the same scope as the Before.

[danroth27]

@rynowak

[rynowak]

Discussed this a bit with @avanderhoorn this morning, he thinks the changes here are pretty minimal and is going to send a PR 👍

[Eilon]

@rynowak parking this on your plate for tracking.

[rynowak]

a0764fa

[avanderhoorn]

Thanks!

On Monday, October 5, 2015, Ryan Nowak [email protected] wrote:

Closed #3204 #3204.

—
Reply to this email directly or view it on GitHub
#3204 (comment).