[Fixes #2896] Made UrlHelper.Content behavior consistent with MVC 5

aspnet · Aug 7, 2015 · b5237b2 · b5237b2
1 parent 94fad91
commit b5237b2
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 13 deletions.
diff --git a/src/Microsoft.AspNet.Mvc.Core/UrlHelper.cs b/src/Microsoft.AspNet.Mvc.Core/UrlHelper.cs
@@ -122,12 +122,19 @@ protected virtual string GeneratePathFromRoute(string routeName, IDictionary<str
         /// <inheritdoc />
         public virtual string Content(string contentPath)
         {
-            if (contentPath == null)
+            if (string.IsNullOrEmpty(contentPath))
             {
                 return null;
             }
+            else if (contentPath[0] == '~')
+            {
+                var segment = new PathString(contentPath.Substring(1));
+                var applicationPath = _httpContext.Request.PathBase;
 
-            return GenerateClientUrl(_httpContext.Request.PathBase, contentPath);
+                return applicationPath.Add(segment).Value;
+            }
+
+            return contentPath;
         }
 
         /// <inheritdoc />
@@ -142,17 +149,6 @@ public virtual string Link(string routeName, object values)
             });
         }
 
-        private static string GenerateClientUrl([NotNull] PathString applicationPath,
-                                                [NotNull] string path)
-        {
-            if (path.StartsWith("~/", StringComparison.Ordinal))
-            {
-                var segment = new PathString(path.Substring(1));
-                return applicationPath.Add(segment).Value;
-            }
-            return path;
-        }
-
         private string GenerateUrl(string protocol, string host, string path, string fragment)
         {
             // We should have a robust and centrallized version of this code. See HttpAbstractions#28

diff --git a/test/Microsoft.AspNet.Mvc.Core.Test/UrlHelperTest.cs b/test/Microsoft.AspNet.Mvc.Core.Test/UrlHelperTest.cs
@@ -45,6 +45,7 @@ public void Content_ReturnsContentPath_WhenItDoesNotStartWithToken(string appRoo
         [InlineData("/", "~/", "/")]
         [InlineData("/myapproot", "~/", "/myapproot/")]
         [InlineData("", "~/Home/About", "/Home/About")]
+        [InlineData("/", "~", "/")]
         [InlineData("/myapproot", "~/Content/bootstrap.css", "/myapproot/Content/bootstrap.css")]
         public void Content_ReturnsAppRelativePath_WhenItStartsWithToken(string appRoot,
                                                                          string contentPath,