Remove ILoggerFactory.MinimumLevel

[Eilon]

This property has two things going against it:

1. Everyone thinks it does something other than what it does. (This can be mitigated by a rename of some sort.)
2. It's not needed anymore. It was added to avoid sensitive information being logged inadvertently. This was later decided to be a non-issue.

This is teh codez: https://github.com/aspnet/Logging/blob/dev/src/Microsoft.Extensions.Logging.Abstractions/ILoggerFactory.cs#L14-L17

@lodejard @muratg @DamianEdwards

[lodejard]

👍 this should have been removed a while ago!

[muratg]

Agreed!

@JunTaoLuo 🎁

[JunTaoLuo]

merged to dev

[joeaudette]

so is there a new way to set the loglevel?

[Eilon]

@joeaudette the thing is, this never set the log level. That's why we're removing it. It just sets the minimum allowed log level. Each individual logger (e.g. DebugLogger, ConsoleLogger, EventLogLogger, SerilogLogger, etc.) has their own configuration and settings to decide what they track.

[joeaudette]

that makes sense, Thanks!

[joeaudette]

just to help others since breaking change announcements usually provide the old and the new way of doing things.
old way:

loggerFactory.MinimumLevel = LogLevel.Warning;
loggerFactory.AddConsole();

new way:

loggerFactory.AddConsole(minLevel: LogLevel.Warning);

[JunTaoLuo]

@joeaudette thanks for the suggestion.

[sunsided]

@joeaudette that makes things clearer indeed.

[Eilon]

BTW, you always needed loggerFactory.AddConsole(minLevel: LogLevel.Warning); to get the right behavior. So in theory a properly-configured app should just remove the call to loggerFactory.MinimumLevel, but everyone was confused, so it was more complicated 😄

[joeaudette]

I'm sure that is true but some people might have thought it was working if the default level happened to correspond to the factory setting even though that didn't do anything. Illustrating the proper way to configure logging is the way to clear up confusion.

Myself I had implemented a custom database logger and provider with my own factory extension that did use the loglevel setting of the factory. So the announcement just saying that setting was removed because it didn't do anything left me initially confused.