This repository has been archived by the owner on Dec 18, 2018. It is now read-only.
Add functional tests, bind to IPv6Any #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should fix #231 |
|
Only half of #231. It doesn't do the localhost -> ::1 & 127.0.0.1 binding. |
|
Yep. Just looked at your comment for the CorrectIPEndpointsAreCreated test. |
Tratcher
force-pushed
the
tratcher/addresses
branch
from
27e0674 to
1f50f4c
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functional tests for address bindings and a partial fix for #231 by binding to IPv6 by default. It uses dual mode sockets so binding to IPv6Any will also accept IPv4 requests.
Also includes disabled functional tests that repro #234 and #232.
@halter73 @lodejard @muratg