Skip to content
This repository has been archived by the owner on Dec 20, 2018. It is now read-only.

Redress cookie name #764

Merged
merged 1 commit into from
Mar 8, 2016
Merged

Redress cookie name #764

merged 1 commit into from
Mar 8, 2016

Conversation

JunTaoLuo
Copy link
Contributor

#763

As part of fixing MusicStore tests in aspnet/MusicStore#601, @natemcmaster found that we are not setting the cookie names correctly for cookies used by Identity. The reason for this is in the referenced issue.

cc @Tratcher @HaoK

@HaoK
Copy link
Member

HaoK commented Mar 7, 2016

What happened to the AspNetCore?

@JunTaoLuo
Copy link
Contributor Author

@natemcmaster
Copy link
Contributor

So to be clear, the expected cookie name is Identity.Application or Identity.External? there is no "Microsoft" or "AspNetCore" anymore?

@JunTaoLuo
Copy link
Contributor Author

No, it is expected to be .AspNetCore.Identity.Application it's just that the .AspNetCore. part is added by Cookies Middleware already.

@natemcmaster
Copy link
Contributor

Ok. LGTM

@JunTaoLuo
Copy link
Contributor Author

ping @HaoK

@HaoK
Copy link
Member

HaoK commented Mar 8, 2016 via email

@JunTaoLuo JunTaoLuo force-pushed the johluo/cookie-name-again branch from bb21329 to 9071b8f Compare March 8, 2016 00:57
@JunTaoLuo JunTaoLuo merged commit 9071b8f into dev Mar 8, 2016
@JunTaoLuo JunTaoLuo deleted the johluo/cookie-name-again branch March 8, 2016 00:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants