This repository has been archived by the owner on Nov 1, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
Forward client certificates. #65
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
56 changes: 56 additions & 0 deletions
56
src/Microsoft.AspNet.IISPlatformHandler/ForwardedTlsConnectionFeature.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
// Copyright (c) .NET Foundation. All rights reserved. | ||
// Licensed under the Apache License, Version 2.0. See License.txt in the project root for license information. | ||
|
||
using System; | ||
using System.Security.Cryptography.X509Certificates; | ||
using System.Threading; | ||
using System.Threading.Tasks; | ||
using Microsoft.AspNet.Http.Features; | ||
using Microsoft.Extensions.Logging; | ||
using Microsoft.Extensions.Primitives; | ||
|
||
namespace Microsoft.AspNet.IISPlatformHandler | ||
{ | ||
internal class ForwardedTlsConnectionFeature : ITlsConnectionFeature | ||
{ | ||
private StringValues _header; | ||
private X509Certificate2 _certificate; | ||
private ILogger _logger; | ||
|
||
public ForwardedTlsConnectionFeature(ILogger logger, StringValues header) | ||
{ | ||
_logger = logger; | ||
_header = header; | ||
} | ||
|
||
public X509Certificate2 ClientCertificate | ||
{ | ||
get | ||
{ | ||
if (_certificate == null && _header != StringValues.Empty) | ||
{ | ||
try | ||
{ | ||
var bytes = Convert.FromBase64String(_header); | ||
_certificate = new X509Certificate2(bytes); | ||
} | ||
catch (Exception ex) | ||
{ | ||
_logger.LogWarning("Failed to read the client certificate.", ex); | ||
} | ||
} | ||
return _certificate; | ||
} | ||
set | ||
{ | ||
_certificate = value; | ||
_header = StringValues.Empty; | ||
} | ||
} | ||
|
||
public Task<X509Certificate2> GetClientCertificateAsync(CancellationToken cancellationToken) | ||
{ | ||
return Task.FromResult(ClientCertificate); | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want to create logger with "ForwardedTlsConnectionFeature" category instead of using "IISPlatformHandlerMiddleware" one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, IISPlatformHandlerMiddleware is more meaningful.