Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

Added extension method to handle the HTTP_PLATFORM_PORT #60

Closed
wants to merge 1 commit into from
Closed

Added extension method to handle the HTTP_PLATFORM_PORT #60

wants to merge 1 commit into from

Conversation

davidfowl
Copy link
Member

Tratcher
Tratcher reviewed Jan 12, 2016
View reviewed changes
src/Microsoft.AspNet.IISPlatformHandler/IISWebApplicationBuilderExtensions.cs
{
public static class IISWebApplicationBuilderExtensions
{
public static IWebApplicationBuilder UseIISPlatformHandler(this IWebApplicationBuilder webApplicationBuilder)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IWebApplicationBuilder.UseIISPlatformHandler needs to be searchably distinct from IApplicationBuilder.UseIISPlatformHandler. UseIISPlatformHandlerUrl?

@Tratcher
Copy link
Member

I was also testing this code path yesterday and found that it fails unless we first remove the same logic from Hosting. Otherwise the address is double registered and kestrel crashes.

@Tratcher
Copy link
Member

#52

This was referenced Jan 12, 2016
Merged
Merged
@davidfowl
Copy link
Member Author

Closing

@davidfowl davidfowl closed this Jan 12, 2016
@natemcmaster natemcmaster deleted the davifowl/platform-handler-extension branch November 1, 2018 06:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidfowl @Tratcher @dnfclas