Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

Add an option allowing to configure the scheme/display name associated with the Windows scheme #391

Closed
kevinchalet opened this issue Jul 3, 2017 · 8 comments
Assignees
Milestone

Comments

@kevinchalet
Copy link

IISMiddleware registers the Windows scheme using the hardcoded null display name. Yet, there are cases where you want to specify a display name so the scheme appears in the external schemes list.

Please add an option to make the display name configurable (and maybe the scheme name too).

https://github.com/aspnet/IISIntegration/blob/dev/src/Microsoft.AspNetCore.Server.IISIntegration/IISMiddleware.cs#L60

Note: this also applies to WebListener.

/cc @Tratcher @HaoK

@kevinchalet
Copy link
Author

@Tratcher not having this option will be blocking for me for at least 3 projects. Is it too late to send a PR adding a DisplayName property to IISOptions? (and optionally, an AuthenticationScheme property)

@Tratcher
Copy link
Member

If you're blocked go ahead and send the PR. We'll see if we can get it approved.

@Tratcher
Copy link
Member

rel/2.0.0 branch

@kevinchalet
Copy link
Author

Okay, will do that tonight.

@Tratcher Tratcher added the bug label Jul 13, 2017
@Tratcher
Copy link
Member

Tentatively approved, I'll do the PR today.

@Tratcher
Copy link
Member

Let me know if you have a compelling reason to set the auth scheme, but not for 2.0.

@kevinchalet
Copy link
Author

@Tratcher haha no, I can live with the scheme not being configurable :trollface:

Do you plan to port the fix to WebListener?

@Tratcher
Copy link
Member

Not sure. It wasn't configurable before, and we still have an open item (that I can't find at the moment) about making WebListener work with individual schemes like it used to. Any plans to use WebListener?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants