Skip to content
This repository has been archived by the owner on Nov 1, 2018. It is now read-only.

Rename UseIIS() to UseIISIntegration() #121

Closed
DamianEdwards opened this issue Apr 7, 2016 · 17 comments
Closed

Rename UseIIS() to UseIISIntegration() #121

DamianEdwards opened this issue Apr 7, 2016 · 17 comments
Assignees
Milestone

Comments

@DamianEdwards
Copy link
Member

It looks strange to have UseIIS() and UseKestrel() in the same call chain when this is really about integrating with IIS while still using Kestrel. Plus it means the name lines up with the package name, etc.

@davidfowl
Copy link
Member

/cc @Tratcher

@dcarr42
Copy link

dcarr42 commented Apr 7, 2016

It seems that integration is tied to kestrel anyway or will there be future different combinations.

@Tratcher
Copy link
Member

Tratcher commented Apr 7, 2016

Kestrel is replaceable. WebListener isn't compatible with AspNetCoreModule right now but we'd like to make it work in the future. You can also plug in 3rd party servers.

@JunTaoLuo
Copy link
Contributor

Create an announcement.

@Tratcher
Copy link
Member

Tratcher commented Apr 7, 2016

Updated the prior announcement.

@Tratcher
Copy link
Member

Tratcher commented Apr 7, 2016

@phenning FYI

@Eilon
Copy link
Member

Eilon commented Apr 8, 2016

@Tratcher close?

@Tratcher
Copy link
Member

Tratcher commented Apr 8, 2016

@Eilon There's still a few repos to clean up. Templates, Performance, cli-samples, etc..

@Tratcher Tratcher closed this as completed Apr 8, 2016
@mikes-gh
Copy link

@Tratcher

Rename UseIIS() to UseIISIntegration()

It seems that this change is in rc3 Package is that intentional?

1.0.0-rc2-20383 UseIIS()
1.0.0-rc3-20540 UseIISIntegration()

@davidfowl
Copy link
Member

It's in both, release is at rc2-20539

@mikes-gh
Copy link

Ah I see I am only picking up 20383 on cidev
Thanks

@mikes-gh
Copy link

Looks like I should be moving to the vnext feed for the buildup to rc2 now?

@mikes-gh
Copy link

As far as I can see vnext is the latest package for rc2 currently
at
1.0.0-rc2-20466

@davidfowl
Copy link
Member

You should use aspnetcirelease if you're tracking the RC2 packages.

@mikes-gh
Copy link

Got it thanks now at 20539. There might be other like me who want to track rc2 to release. If there is no announcement maybe an issue post in Home?

@Tratcher
Copy link
Member

@mikes-gh I mentioned this on an existing announcement and updated the sample code. #105 (comment)

@mikes-gh
Copy link

@Tratcher thanks
Actually I was referring to an announcement for the change of feeds to continue using updated rc2 packages
There is an article of feeds but I hadn't realised release was now the active branch (and others might not also).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants