This repository has been archived by the owner on Nov 20, 2018. It is now read-only.
Consolidate auth APIs #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Update to include #273 - POCO context objects. |
| HttpResponseFeature.StatusCode = 401; | ||
| var handler = HttpAuthenticationFeature.Handler; | ||
|
|
||
| var challengeContext = new ChallengeContext(authenticationScheme, properties == null ? null : properties.Items); |
|
Updated and rebased. |
|
Updated with related changes for WebSockets. #267 |
| { | ||
| get | ||
| { | ||
| var webSocketFeature = WebSocketFeature; |
There was a problem hiding this comment.
Why not use the property directly? Do we need to assign it to a variable?
|
Code changes look good to me and reflect the discussions from the API review. @davidfowl does new API surface look good to you? |
| Challenge(properties: null, authenticationScheme: authenticationScheme); | ||
| } | ||
|
|
||
| public abstract void Challenge(AuthenticationProperties properties, string authenticationScheme); |
There was a problem hiding this comment.
I agree with Brent's issue, we should probably switch scheme to be the first parameter here to be consistent with sign in/signout
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#266 - Consolidate all the auth APIs to HttpContext.Authentication
#270 - Naming
@davidfowl @muratg
/cc @HaoK