Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

UseBuilder should take optional Action<IServiceCollection> #398

Closed
davidfowl opened this issue Sep 14, 2015 · 3 comments
Closed

UseBuilder should take optional Action<IServiceCollection> #398

davidfowl opened this issue Sep 14, 2015 · 3 comments
Assignees
@JunTaoLuo
Labels
3 - Done bug
Milestone
1.0.0-rc2

Comments

@davidfowl
Copy link
Member

To make it easier to configure services in the ASP.NET 5 pipeline when exposed via Owin
@muratg
Copy link

muratg commented Sep 14, 2015

Won't the overload with Action<IApplicationBuilder> be enough for that? It has a ServiceProvider property.

@Tratcher
Copy link
Member

Except ServiceProvider is null:

HttpAbstractions/src/Microsoft.AspNet.Owin/OwinExtensions.cs

Line 72 in f475e53

var builder = new ApplicationBuilder(serviceProvider: null);

@muratg muratg added this to the 1.0.0-beta8 milestone Sep 14, 2015
@Eilon Eilon modified the milestones: 1.0.0-rc1, 1.0.0-beta8 Sep 17, 2015
@Tratcher Tratcher modified the milestones: 1.0.0-rc2, 1.0.0-rc1 Oct 22, 2015
@Tratcher Tratcher assigned JunTaoLuo and unassigned Tratcher Nov 3, 2015
JunTaoLuo added a commit that referenced this issue Nov 9, 2015
@JunTaoLuo
Adding option to configure services when exposing the ASP.NET 5 pipel…
a2a796b 
…ine via OWIN #398
JunTaoLuo added a commit that referenced this issue Nov 9, 2015
@JunTaoLuo
Adding option to configure services when exposing the ASP.NET 5 pipel…
128e135 
…ine via OWIN #398
@JunTaoLuo JunTaoLuo mentioned this issue Nov 9, 2015
Merged
JunTaoLuo added a commit that referenced this issue Nov 11, 2015
@JunTaoLuo
Adding option to configure services when exposing the ASP.NET 5 pipel…
8f4c409 
…ine via OWIN #398
JunTaoLuo added a commit that referenced this issue Nov 17, 2015
@JunTaoLuo
Adding option to configure services when exposing the ASP.NET 5 pipel…
35e25ee 
…ine via OWIN #398
JunTaoLuo added a commit that referenced this issue Nov 17, 2015
@JunTaoLuo
Adding option to configure services when exposing the ASP.NET 5 pipel…
19e42a4 
…ine via OWIN #398
JunTaoLuo added a commit that referenced this issue Nov 17, 2015
@JunTaoLuo
Adding option to configure services when exposing the ASP.NET 5 pipel…
fbec068 
…ine via OWIN #398
@JunTaoLuo
Copy link
Contributor

merged to dev

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@JunTaoLuo JunTaoLuo

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-rc2
Development

No branches or pull requests
5 participants
@davidfowl @Eilon @muratg @Tratcher @JunTaoLuo