Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

Add StringValues struct for collections #361

Closed
lodejard opened this issue Aug 4, 2015 · 8 comments
Closed

Add StringValues struct for collections #361

lodejard opened this issue Aug 4, 2015 · 8 comments

Comments

@lodejard
Copy link
Contributor

lodejard commented Aug 4, 2015

Streamlines all of the cases where string,string[] collections cause friction

Also has side-effect of reducing number of allocations per request

@Tratcher
Copy link
Member

Tratcher commented Aug 4, 2015

What did the CLR team have to say about this?

Also, layering. Ideally this type would be in a BCL package, not one of ours.

@Eilon
Copy link
Member

Eilon commented Aug 5, 2015

As with many types, we should start out with our own and see where it goes.

@davidfowl
Copy link
Member

+1

@glennc glennc added this to the 1.0.0-beta7 milestone Aug 5, 2015
@lodejard
Copy link
Contributor Author

lodejard commented Aug 5, 2015

I'm not sure this is necessarily a BCL/CLR asset, we certainly don't need to be gated by that for packaged code. Nothing else in HttpAbstractions and web server feature interfaces was punched down that far.

@davidfowl
Copy link
Member

@Tratcher is concerned because of the layering of WebListener. The lower layer doesn't depend on anything except bcl types today

@Eilon
Copy link
Member

Eilon commented Aug 5, 2015

WebListener is a DNX-only component in practice, but either way, having it depend on another package is really not so bad.

@Tratcher
Copy link
Member

Tratcher commented Aug 5, 2015

@lodejard Do you have your prototype code in a branch? Or paste it here?

@lodejard
Copy link
Contributor Author

lodejard commented Aug 7, 2015

@Tratcher Tratcher modified the milestones: 1.0.0-beta8, 1.0.0-beta7 Aug 13, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants