Skip to content
This repository has been archived by the owner on Nov 20, 2018. It is now read-only.

ApiReview: Make most properties settable on HttpContext, HttpRequest, HttpResponse, etc. #272

Closed
Tratcher opened this issue Apr 14, 2015 · 2 comments

Comments

@Tratcher
Copy link
Member

Anything that makes sense to set during testing.

Yes:
Items (& IItemsFeature.Items)
RequestAborted
Request.Cookies (& IRequestCookiesFeature.Cookies)
Request.IsHttps
Request.Query (& IQueryFeature.Query)

Maybe:
Request, Response
Request.Headers
Response.Headers
Response.HeadersSent
Response.Cookies - not a collection

No:
IsWebSocketRequest (You have to replace the entire feature for testing)
WebSocketRequestedProtocols
Request.HasFormContentType (set the Form property instead)

@Tratcher
Copy link
Member Author

Remove DefaultHttpContext.Revision.

@Tratcher Tratcher added this to the 1.0.0-beta5 milestone May 6, 2015
@Tratcher Tratcher self-assigned this May 6, 2015
@Tratcher
Copy link
Member Author

HttpContext.Session can't be easily set. The property is an ISessionCollection, but the feature stores an ISession that the collection wraps. We may need to think about the layering there.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant