Skip to content
This repository has been archived by the owner on Nov 6, 2018. It is now read-only.

Modify PollingWildCardChangeToken to include the timestamp of the files along with the names as part of hash check #238

Closed
pranavkm opened this issue Sep 29, 2016 · 2 comments
Assignees

Comments

@pranavkm
Copy link
Contributor

Consider the following timeline

t0 ->  Create a copy of  File.txt to a backup directory . 
t1 -> Modify File.txt with contents different from the original file.
t2 -> Move the file from the backup directory to the original location.

The PollingWildCardChangeToken only carries the timestamp of the most recently changed last write time window. Consequently this wouldn't work when a file is modified but it's timestamp hasn't moved forward. We could avoid this by additionally storing the timestamp along with the name of the file.

@pranavkm
Copy link
Contributor Author

cc @Eilon

@Eilon
Copy link
Member

Eilon commented Sep 30, 2016

Not a task. This is a genuine bug. Tasks are for code cleanup!

@Eilon Eilon added bug and removed task labels Sep 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants