Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migrations] Implement SqlOperation.SuppressTransaction #2558

Closed
natemcmaster opened this issue Jul 7, 2015 · 5 comments
Closed

[Migrations] Implement SqlOperation.SuppressTransaction #2558

natemcmaster opened this issue Jul 7, 2015 · 5 comments
Assignees
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone

Comments

@natemcmaster
Copy link
Contributor

It's configured available in the API, but not actually implemented.

We need this functionality to work to support certain SQLite migrations.

@bricelam
Copy link
Contributor

bricelam commented Jul 8, 2015

@mikary may or may not already be looking in to this...

@mikary
Copy link
Contributor

mikary commented Jul 8, 2015

I did some digging around as a result of my work on #1863 (PR #2520) and noticed that we have two different ways of building commands (CommandBuilder and SqlStatementExecutor) and different batching systems for Migrations, Modification Commands, and Query. As far as I've seen, only Modification Commands respect the MaxBatchSize #2154. We also have a number of SQL generation patterns #2493 and from what I've seen of the factoring there is a lot of duplicated code.

While there isn't a specific issue tracking it, I would like to refactor/unify this code.

@natemcmaster
Copy link
Contributor Author

As we discussed, for SQLite's purposed, it would be better to implement this to end the current transaction and begin a new one after the MigrationOperation executes. This will preserve ordering.

@mikary
Copy link
Contributor

mikary commented Aug 21, 2015

Removed transaction suppression in #2758, will need to begin looking at it in light of new consolidated command building.

@mikary
Copy link
Contributor

mikary commented Apr 20, 2016

Added transaction suppression in #4917

@mikary mikary closed this as completed Apr 20, 2016
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Development

No branches or pull requests

5 participants