Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and rationalize SQL generation #2493

Closed
ajcvickers opened this issue Jun 29, 2015 · 3 comments
Closed

Consolidate and rationalize SQL generation #2493

ajcvickers opened this issue Jun 29, 2015 · 3 comments
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-unknown
Milestone

Comments

@ajcvickers
Copy link
Contributor

Currently different parts of the stack do SQL generation in different ways. This may be fine since, for example, query and update have different mechanisms and requirements. However, we should make sure that we are using common code where it makes sense. If nothing else, code for escaping, etc. should be able to be shared. Related to this is that if a provider needs to customize how things like escaping are done, then the provider should only need to do this in one place.

@rowanmiller
Copy link
Contributor

Make sure we API review IUpdateSqlGenerator et al before closing this

@rowanmiller rowanmiller modified the milestones: 7.0.0-rc1, 7.0.0 Sep 17, 2015
@rowanmiller
Copy link
Contributor

This should be a very scoped refactoring just to ensure providers don't have to override escaping etc. in multiple places

@rowanmiller
Copy link
Contributor

We are happy with what we have now

@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Oct 15, 2022
@ajcvickers ajcvickers modified the milestones: 1.0.0-rc1, 1.0.0 Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-unknown
Projects
None yet
Development

No branches or pull requests

4 participants