This repository has been archived by the owner on Dec 8, 2018. It is now read-only.
Fix Apply Migrations button #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During all the changes to how options are handled etc. we ended up where app.UseDatabaseErrorPage() would no longer register the migrations middleware that allows the "Apply Migrations" button to work. Resolves dotnet/efcore#4742
| @@ -26,7 +25,7 @@ public static IApplicationBuilder UseDatabaseErrorPage(this IApplicationBuilder | |||
| throw new ArgumentNullException(nameof(app)); | |||
| } | |||
|
|
|||
| return app.UseMiddleware<DatabaseErrorPageMiddleware>(); | |||
| return app.UseDatabaseErrorPage(new DatabaseErrorPageOptions()); | |||
There was a problem hiding this comment.
Curious - why didn't the old code work?
There was a problem hiding this comment.
It looks like MigrationsEndPointMiddleware was never wired up on this code path. The error page would show up, but the endpoint to apply migrations was never added.
There was a problem hiding this comment.
Yep, the migrations end point is a separate piece of middleware. The overload we now delegate to adds both pieces of middleware.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During all the changes to how options are handled etc. we ended up where
app.UseDatabaseErrorPage() would no longer register the migrations
middleware that allows the "Apply Migrations" button to work.
Resolves dotnet/efcore#4742