Skip to content
This repository has been archived by the owner on Nov 22, 2018. It is now read-only.

Make HTTP method match as case-insensitive #77

Closed
rynowak opened this issue May 5, 2016 · 9 comments
Closed

Make HTTP method match as case-insensitive #77

rynowak opened this issue May 5, 2016 · 9 comments
Assignees

Comments

@rynowak
Copy link
Member

rynowak commented May 5, 2016

I know the spec says that HTTP methods are case-sensitive - but don't we do this other places?

https://github.com/aspnet/CORS/blob/dev/src/Microsoft.AspNetCore.Cors/Infrastructure/CorsMiddleware.cs#L103

@rynowak
Copy link
Member Author

rynowak commented May 5, 2016

/cc @Tratcher

@davidfowl
Copy link
Member

We should not, we should be case insensitive where we can.

@rynowak
Copy link
Member Author

rynowak commented May 5, 2016

We should not, we should be case insensitive where we can.

Error CS1092: Statement ambiguous

@davidfowl
Copy link
Member

I misread the link, we should be case insensitive and fix this code 😄

@rynowak
Copy link
Member Author

rynowak commented May 5, 2016

Are you saying we should change the other stuff?

@davidfowl
Copy link
Member

It should be case insensitive across the board

@Tratcher
Copy link
Member

Tratcher commented May 5, 2016

Agreed, case insensitive.

@Eilon Eilon added this to the 1.0.0 milestone May 5, 2016
@Eilon
Copy link
Member

Eilon commented May 5, 2016

@Tratcher are there other areas where we are not case-sensitive, but should be?

@Eilon
Copy link
Member

Eilon commented May 17, 2016

Moving to post-RTM.

@Eilon Eilon modified the milestones: 1.0.1, 1.0.0 May 17, 2016
@kichalla kichalla changed the title Should we treat HTTP method as case-insensitive? Make HTTP method match as case-insensitive Aug 3, 2016
kichalla added a commit to aspnet/Mvc that referenced this issue Aug 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants