Generate missing component.headers types
#244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@solufa はじめまして。レビューをお願いできますでしょうか…？ |
|
@mashabow |
|
@solufa ありがとうございました！ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Changes
When specifying the schema of the response headers using
components.headers, their types are not generated in@types/index.ts. This issue seems similar to #211 and #218, so I fixed it by referring to those PRs.レスポンスヘッダのスキーマを
components.headersを使って指定している場合、その型が@types/index.tsに生成されないようです。#211, #218 と似た問題のようなので、そちらを参考にして修正してみました。Additional context
Community note
Please upvote with reacting as 👍 to express your agreement.