Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #156 #170

Merged
4 commits merged into from Mar 1, 2022
Merged

fix: #156 #170

4 commits merged into from Mar 1, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 15, 2022

Types of changes

What kind of change does this PR introduce? (check at least one)

  • Breaking change
  • Bugfix
  • Feature
  • Code style update
  • Refactoring
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Description

Issue Number: #156

@ghost ghost changed the base branch from master to develop February 15, 2022 02:03
@ghost ghost requested a review from LumaKernel February 28, 2022 00:12
@LumaKernel
Copy link
Contributor

please rebase or merge main

@ghost
Copy link
Author

ghost commented Feb 28, 2022 •
edited by ghost
Loading

@LumaKernel
I rebased main branch. but CI is still dropping…

@LumaKernel
Copy link
Contributor

you may see your tests failing in your local environment now. typing : File | ReadStream added into main after your PR opening.

@ghost
Copy link
Author

ghost commented Feb 28, 2022

OK. I'll check it.

LumaKernel
LumaKernel requested changes Feb 28, 2022
View reviewed changes
Copy link
Contributor

@LumaKernel LumaKernel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add sample to show 156 is solved? I can't see whether 156 is fixed only by diff.

@ghost ghost merged commit 0a7d608 into aspida:main Mar 1, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LumaKernel