Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add configure_mode & configure_devtool attributes to webpack_bundle and webpack_devserver #112

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Mar 24, 2023

In some cases, users don't want the generated base config to touch mode & devtool

@jbedard
Copy link
Member

jbedard commented Mar 24, 2023

These can't be overridden in the user config files? We need to explicitly not set them? 🫤

@gregmagolan
Copy link
Member Author

These can't be overridden in the user config files? We need to explicitly not set them? 🫤

They can be but users might not pass config files or just want the default behaviour

@jbedard
Copy link
Member

jbedard commented Mar 24, 2023

How common is it to not have a config and not want default behavior? If it's rare I'd vote to not add more to the API. Or maybe add a single flag "use_defaults" or something like that? Then that flag can just swap between preset config files...

@gregmagolan
Copy link
Member Author

So far one request from a client but it is a low sample size so I don't think we can know how common it will be.
I considered use_defaults but the generated base config does have sane and useful defaults for infrastructureLogging, optimization & output that I don't think makes sense to be able to turn off. Just mode and devtool are the contentious ones for the client.

@gregmagolan gregmagolan requested a review from kormide March 24, 2023 19:30
@gregmagolan gregmagolan merged commit 493e78c into main Mar 25, 2023
@gregmagolan gregmagolan deleted the opt_out_custom_config branch March 25, 2023 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants