Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove vendored webpack versions, user must provider their own webpack tool from their node_modules #110

Merged
merged 3 commits into from
Mar 20, 2023

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Mar 19, 2023

My proposed pattern to use instead of vendoring the package.json & pnpm lock file for all versions of webpack.

This is a BREAKING CHANGE and should be pointed out in the release notes of the next release.

  • remove A LOT of complexity from the repository
  • solves the duplicate webpack found in node_modules directories problem
  • reduces the maintenance burden of adding new versions of webpack to versions.bzl
  • resolved the difficulty of getting rules_webpack onto bzlmod

After landing the same pattern would rolled out to rules_jasmine, rules_jest, rules_rollup & rules_terser which are all pre-1.0 still.

@gregmagolan gregmagolan requested review from jbedard and kormide March 19, 2023 17:23
@gregmagolan gregmagolan force-pushed the no_vendored_webpack branch 3 times, most recently from 616a104 to bb3571b Compare March 19, 2023 17:30
@gregmagolan gregmagolan force-pushed the no_vendored_webpack branch from bb3571b to fc5dce6 Compare March 19, 2023 18:33
Copy link
Member

@kormide kormide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🦖 . So much cleaner.

@kormide
Copy link
Member

kormide commented Mar 19, 2023

Can we remove webpack_binary from the public defs now?

@jbedard
Copy link
Member

jbedard commented Mar 20, 2023

What happens if a user doesn't have the 3 npm packages installed? Do they get any error message explaining it?

Is the webpack-dev-server package required if you don't use the webpack_devserver rule?

Overall seems way less complicated to me, especially when users have things like webpack plugin npm packages that need to mix with the vendored one etc.

@gregmagolan gregmagolan force-pushed the no_vendored_webpack branch 5 times, most recently from 20bef7f to 6bae474 Compare March 20, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants