-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: remove vendored webpack versions, user must provider their own webpack tool from their node_modules #110
Conversation
616a104
to
bb3571b
Compare
…own webpack tool from their node_modules
bb3571b
to
fc5dce6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice 🦖 . So much cleaner.
Can we remove |
What happens if a user doesn't have the 3 npm packages installed? Do they get any error message explaining it? Is the Overall seems way less complicated to me, especially when users have things like webpack plugin npm packages that need to mix with the vendored one etc. |
20bef7f
to
6bae474
Compare
6bae474
to
23a0669
Compare
My proposed pattern to use instead of vendoring the package.json & pnpm lock file for all versions of webpack.
This is a BREAKING CHANGE and should be pointed out in the release notes of the next release.
After landing the same pattern would rolled out to rules_jasmine, rules_jest, rules_rollup & rules_terser which are all pre-1.0 still.