Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ts_project declaration sources from other directories #729

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 31, 2024

Fix #727


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

@jbedard jbedard requested a review from dzbarsky October 31, 2024 20:16
Copy link

aspect-workflows bot commented Oct 31, 2024

Test

All tests were cache hits

149 tests (100.0%) were fully cached saving 9s.


Buildifier      Format

@jbedard jbedard force-pushed the tsconfig-files-bad branch from d7a1b63 to 7b521d9 Compare October 31, 2024 20:38
@jbedard jbedard enabled auto-merge (squash) October 31, 2024 20:46
ts/private/ts_config.bzl Outdated Show resolved Hide resolved
@jbedard jbedard force-pushed the tsconfig-files-bad branch from 7b521d9 to fd2b883 Compare November 4, 2024 23:51
@jbedard jbedard merged commit e852fc0 into aspect-build:main Nov 5, 2024
24 checks passed
@jbedard jbedard deleted the tsconfig-files-bad branch November 5, 2024 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ts_project error when srcs include parent/sibling files
2 participants