Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make //ts:skipLibCheck flag public #709

Merged
merged 1 commit into from
Oct 7, 2024

Conversation

gzm0
Copy link
Contributor

@gzm0 gzm0 commented Oct 7, 2024

Likely an oversight: all other flags below are public.

We would like to alias this flag to hide the rules_ts dependency and cannot because of the visibility.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: Doc update IMO unnecessary.
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: no

Test plan

  • Covered by existing test cases

Likely an oversight: all other flags below are public.

We would like to alias this flag to hide the rules_ts dependency and
cannot because of the visibility.
Copy link

aspect-workflows bot commented Oct 7, 2024

Test

All tests were cache hits

136 tests (100.0%) were fully cached saving 10s.


Buildifier      Format

@jbedard jbedard merged commit bdd0fa9 into aspect-build:main Oct 7, 2024
24 checks passed
@gzm0 gzm0 deleted the public-flag branch October 8, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants