perf: remove unnecessary tsconfig relative_file computation #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jbedard
force-pushed
the
tsconfig-rel-files
branch
from
ab2ce2d to
bbae1cd
Compare
jbedard
force-pushed
the
tsconfig-rel-files
branch
from
bbae1cd to
d68a409
Compare
|
This saves us around 300ms Before: After: |
jbedard
force-pushed
the
tsconfig-rel-files
branch
from
d68a409 to
4ed820b
Compare
thesayyn
approved these changes
Sep 9, 2024
jbedard
pushed a commit
that referenced
this pull request
Oct 28, 2024
Fix after breakage from #687 ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases - New test cases added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tsconfig is only generated within the BUILD directory and there is an assert that the
srcsare all within that directory, so the relative file paths are easy to compute.Changes are visible to end-users: no
Test plan