Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: remove duplicate path.removeprefix calls #686

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Sep 7, 2024

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@jbedard jbedard requested a review from alexeagle September 7, 2024 18:49
Copy link

aspect-workflows bot commented Sep 7, 2024

Test

All tests were cache hits

84 tests (100.0%) were fully cached saving 8s.


Buildifier      Format

@jbedard jbedard requested a review from thesayyn September 9, 2024 19:13
@jbedard jbedard merged commit 2bacaea into aspect-build:main Sep 9, 2024
23 checks passed
@jbedard jbedard deleted the removeprefix-dupe branch September 9, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants