-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: emit declarations with a tool other than tsc #648
Conversation
Will do the action re-wiring in a follow-up PR, this is already a minimal unit on its own
…ss set explicitly
@@ -5,7 +5,8 @@ ts_project( | |||
name = "backend", | |||
declaration = True, | |||
tsconfig = "//examples/isolated_declarations:tsconfig", | |||
deps = ["//examples/isolated_declarations/core"], | |||
# FIXME: should just be core:core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jbedard this is the next step in the PR, to make the SWC-transpiled declarations appear as the types on the terminal rule in the macro produced for core:core
. I have to juggle the logic for when to produce a js_library
target "tree".
Also before landing this I think the declaration producing rule should be in rules_swc rather than a bzl file here.
@alexeagle this is really exciting |
Done in #697 |
Mirrors how the
transpiler
attribute works.Here's a profile, showing that
frontend
andbackend
targets are type-checked in parallel withcore
even though they both depend on it. The small green boxes in the upper-left are the 10msswc
action that produces thecore/index.d.ts
file needed by the type-checker forfrontend
andbackend
Changes are visible to end-users: yes
Test plan