Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: transitive ts_project npm: deps #635

Merged
merged 1 commit into from
Jun 27, 2024
Merged

test: transitive ts_project npm: deps #635

merged 1 commit into from
Jun 27, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jun 25, 2024

Changes are visible to end-users: no

Test plan

  • New test cases added

@jbedard jbedard requested review from gregmagolan and thesayyn June 25, 2024 17:35
@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Jun 25, 2024 •
edited
Loading

Test

2 test targets passed

Targets 
//examples/linked_consumer:direct [k8-fastbuild] 152ms
//examples/linked_consumer:pkg [k8-fastbuild]    133ms

Total test execution time was 285ms. 77 tests (97.5%) were fully cached saving 13s.

Buildifier      Format

@jbedard jbedard requested a review from alexeagle June 26, 2024 00:25
@jbedard jbedard enabled auto-merge (squash) June 26, 2024 00:25
thesayyn
thesayyn approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great test case.

@jbedard jbedard merged commit a122c68 into aspect-build:main Jun 27, 2024
23 checks passed
alexeagle pushed a commit to MichaelMitchell-at/rules_ts that referenced this pull request Jun 29, 2024
@jbedard @alexeagle
test: transitive ts_project npm: deps (aspect-build#635)
4bb3ff1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn approved these changes

@gregmagolan gregmagolan Awaiting requested review from gregmagolan

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbedard @thesayyn