fix(ts_proto_library): require explicit srcs to copy #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…D file error: `Error in directory_path: directory_path rule '_logger_pb.d.ts_dirpath' in package 'examples/proto_grpc' conflicts with existing directory_path rule`
The hack of using a glob over the srcs causes a collision when there is more than one ts_proto_library in a bazel package. The resulting error doesn't give a clue what fix is required.
|
|
|
mrmeku
approved these changes
Jun 2, 2024
There was a problem hiding this comment.
It’s a shame we are in macro land and can’t reference the ProtoInfo provider. Maybe in the future we can convert the rule to use the implementation more directly
https://docs.bazel.build/versions/5.3.1/skylark/lib/ProtoInfo.html#direct_sources
alexeagle
added a commit
that referenced
this pull request
Jun 3, 2024
* Example on bazel failing when 2 ts_proto_library are in a single BUILD file error: `Error in directory_path: directory_path rule '_logger_pb.d.ts_dirpath' in package 'examples/proto_grpc' conflicts with existing directory_path rule` * fix: explicit files_to_copy for multiple ts_proto_lib * fix(ts_proto_library): require explicit srcs to copy The hack of using a glob over the srcs causes a collision when there is more than one ts_proto_library in a bazel package. The resulting error doesn't give a clue what fix is required. * chore: docgen * fix: docs --------- Co-authored-by: egorm <[email protected]>
alexeagle
added a commit
that referenced
this pull request
Jun 3, 2024
* Example on bazel failing when 2 ts_proto_library are in a single BUILD file error: `Error in directory_path: directory_path rule '_logger_pb.d.ts_dirpath' in package 'examples/proto_grpc' conflicts with existing directory_path rule` * fix: explicit files_to_copy for multiple ts_proto_lib * fix(ts_proto_library): require explicit srcs to copy The hack of using a glob over the srcs causes a collision when there is more than one ts_proto_library in a bazel package. The resulting error doesn't give a clue what fix is required. * chore: docgen * fix: docs --------- Co-authored-by: egorm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The hack of using a glob over the srcs causes a collision when there is more than one ts_proto_library in a bazel package.
The resulting error doesn't give a clue what fix is required.
Changes are visible to end-users: yes
When ts_proto_library#copy_files is True, users must now repeat the .proto files whose outputs should be copied.
Test plan