Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to bazel 6.0.0rc2 #249

Merged
merged 1 commit into from
Nov 20, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelversion
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
6.0.0rc1
6.0.0rc2
# The first line of this file is used by Bazelisk and Bazel to be sure
# the right version of Bazel is used to build and test this repo.
# This also defines which version is used on CI.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ build:local --disk_cache=~/.cache/bazel

# Generic remote cache
build --remote_local_fallback
# build --remote_download_toplevel # BREAKS BUILD in Bazel 6.0.0rc1
# build --remote_download_toplevel # BREAKS BUILD in Bazel 6.0.0rc1 & rc2; See https://github.com/bazelbuild/bazel/issues/16789
build --remote_timeout=3600
build --remote_upload_local_results
## Fixes builds hanging on CI that get the TCP connection closed without sending RST packets.
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
# Don't run RBE if there are no EngFlow creds which is the case on forks
if: ${{ env.ENGFLOW_PRIVATE_KEY != '' }}
outputs:
# Will look like '["local", "rbe"]'
# Will look like ["local", "rbe"]
configs: ${{ toJSON(steps.*.outputs.config) }}

matrix-prep-bazelversion:
Expand All @@ -44,7 +44,7 @@ jobs:
- id: bazel_5
run: echo "bazelversion=5.3.2" >> $GITHUB_OUTPUT
outputs:
# Will look like '["6.0.0rc1", "5.3.2"]'
# Will look like ["<version from .bazelversion>", "5.3.2"]
bazelversions: ${{ toJSON(steps.*.outputs.bazelversion) }}

test:
Expand Down Expand Up @@ -134,10 +134,10 @@ jobs:

- run: go install github.com/bazelbuild/buildtools/buildozer@latest
if: ${{ hashFiles(format('{0}/test.sh', matrix.folder)) != '' }}

- uses: pnpm/action-setup@v2
with:
version: '7.14.2'
version: '7.14.2'

- name: run ./test.sh
working-directory: ${{ matrix.folder }}
Expand Down