fix: support non-file transpiler srcs #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
reviewed
Nov 9, 2022
thesayyn
reviewed
Nov 9, 2022
|
i wonder how would this work when the build is; filegroup(name = "filegroup", srcs = ["1.ts", "2.ts"])
ts_project(
srcs = [":filegroup"]
) |
jbedard
force-pushed
the
transpiler-api
branch
from
17a80d5 to
c9b9449
Compare
alexeagle
changed the title
alexeagle
approved these changes
Nov 10, 2022
jbedard
force-pushed
the
transpiler-api
branch
3 times, most recently
from
d489fd7 to
f50e781
Compare
jbedard
commented
Nov 11, 2022
jbedard
commented
Nov 11, 2022
jbedard
force-pushed
the
transpiler-api
branch
from
f50e781 to
6458179
Compare
thesayyn
reviewed
Nov 11, 2022
The js_outs and map_outs attributes have been removed and all sources are passed including non .ts files. Transpilers should produce .js files for each inputted .ts file. Additional features such as generation of source maps (.js.map) may be implemented and should respect the the ts_project(source_map) attribute. Transpilers may optionally pre-declare output files similar to ts_project(). Fixes aspect-build#219
jbedard
force-pushed
the
transpiler-api
branch
from
6458179 to
eb7f4b8
Compare
alexeagle
approved these changes
Nov 13, 2022
|
Good to merge then? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current transpiler which takes 3 arrays with aligning indexes is a bad API, and to fix #219 one of those arrays will no longer align with the other 2 making it unusable.
Proposed solution in this PR: #219 (comment)
This change makes the transpiler API simply
transpiler(srcs). Any additional information required should be added viapartial.makesuch asout_dir,source_mapetc. Often these extra params will be required in order to align with thets_projectattributes. A macro will almost always be ideal to configure the transpiler including things like aligning these attributes.swc change to do its own output declarations: aspect-build/rules_swc@f716962
ts/test/mock_transpiler.bzl is an example implementing a full rule including support for non-file srcs and predeclaring the .js and .js.map outputs.
examples/transpiler/babel.bzl is an example of a macro keeping the same functionality as today where it only supports file inputs. This also predeclares the .js and .js.map outputs as part of the babel invocation.
Alternatives:
changingjs/map_outsto maps is a lot nicer then 3 arrays where the indexes align, especially since fixing targets (non-files) insrcsbreaks the index-aligning. See 17a80d5