Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add case for filegroup of srcs #211

Merged
merged 2 commits into from
Oct 31, 2022
Merged

test: add case for filegroup of srcs #211

merged 2 commits into from
Oct 31, 2022

Conversation

alexeagle
Copy link
Member

Part of #23

@alexeagle alexeagle requested a review from jbedard October 31, 2022 20:21
@alexeagle alexeagle enabled auto-merge (squash) October 31, 2022 20:25
@jbedard
Copy link
Member

jbedard commented Oct 31, 2022

How about generated files? A genrule that just copies the ts files?

@alexeagle
Copy link
Member Author

We have that in examples/simple already. I'll move it over here since generated code isn't the simple case.

@jbedard jbedard disabled auto-merge October 31, 2022 20:42
@jbedard
Copy link
Member

jbedard commented Oct 31, 2022

In this PR or another?

@alexeagle
Copy link
Member Author

moved it here, PTAL

jbedard
jbedard approved these changes Oct 31, 2022
View reviewed changes
Copy link
Member

@jbedard jbedard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alexeagle alexeagle merged commit beb1807 into main Oct 31, 2022
@alexeagle alexeagle deleted the example3 branch October 31, 2022 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexeagle @jbedard