Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove /node_modules/. from ignored paths #185

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Conversation

thesayyn
Copy link
Member

@thesayyn thesayyn commented Oct 21, 2022

fixes #183

@gregmagolan gregmagolan added this to the 1.0 milestone Nov 1, 2022
@thesayyn thesayyn marked this pull request as ready for review November 7, 2022 17:20
@thesayyn thesayyn force-pushed the fix-ignored-paths branch 11 times, most recently from c027c72 to 5aacfd2 Compare November 8, 2022 03:29
@thesayyn thesayyn force-pushed the fix-ignored-paths branch 3 times, most recently from 93f709d to 21d1833 Compare November 9, 2022 17:38
@gregmagolan
Copy link
Member

Looks like you have to try/catch on the lstat to handle the file does not exist ENOENT case?

==================== Test output for //ts/test/ts_project_worker:fstree_test:
node:internal/fs/utils:344
    throw err;
    ^

Error: ENOENT: no such file or directory, lstat '/home/runner/.cache/bazel/_bazel_runner/537fa4813b44af3837a26a2cda63cb2b/sandbox/linux-sandbox/417/execroot/aspect_rules_ts/_tmp/4[58](https://github.com/aspect-build/rules_ts/actions/runs/3430459081/jobs/5717451300#step:6:59)5122692a90866cc108a43b4f7d3a8/tree/subtree/input.js'
    at Object.lstatSync (node:fs:1514:3)
    at Object.lstatSync (/home/runner/.cache/bazel/_bazel_runner/537fa4813b44af3837a26a2cda63cb2b/external/aspect_rules_js/js/private/node-patches/fs.js:110:23)
    at Object.add (/home/runner/.cache/bazel/_bazel_runner/537fa4813b44af3837a26a2cda63cb2b/sandbox/linux-sandbox/417/execroot/aspect_rules_ts/bazel-out/k8-fastbuild/bin/ts/test/ts_project_worker/fstree_test.sh.runfiles/aspect_rules_ts/ts/test/ts_project_worker/ts_project_worker.js:104:25)
    at Object.<anonymous> (/home/runner/.cache/bazel/_bazel_runner/537fa4813b44af3837a26a2cda[63](https://github.com/aspect-build/rules_ts/actions/runs/3430459081/jobs/5717451300#step:6:64)cb2b/sandbox/linux-sandbox/417/execroot/aspect_rules_ts/bazel-out/k8-fastbuild/bin/ts/test/ts_project_worker/fstree_test.sh.runfiles/aspect_rules_ts/ts/test/ts_project_worker/fstree.test.js:16:6)
    at Module._compile (node:internal/modules/cjs/loader:1101:14)
    at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
    at Module.load (node:internal/modules/cjs/loader:981:32)
    at Function.Module._load (node:internal/modules/cjs/loader:822:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:79:12)
    at node:internal/main/run_main_module:17:47 {
  errno: -2,
  syscall: 'lstat',
  code: 'ENOENT',
  path: '/home/runner/.cache/bazel/_bazel_runner/537fa4813b44af3837a26a2cda63cb2b/sandbox/linux-sandbox/417/execroot/aspect_rules_ts/_tmp/4585122692a908[66](https://github.com/aspect-build/rules_ts/actions/runs/3430459081/jobs/5717451300#step:6:67)cc108a43b4f7d3a8/tree/subtree/input.js'
}

@thesayyn thesayyn merged commit 20697ec into main Nov 11, 2022
@thesayyn thesayyn deleted the fix-ignored-paths branch November 11, 2022 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker dependency issue
3 participants