fix: ts_project fails if root_dir used deep in source tree
#130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jbedard
approved these changes
Aug 16, 2022
|
Thanks! 👍 The CLA is still a WIP? |
thesayyn
approved these changes
Aug 16, 2022
Yeah, I just sent it over to them today. Hopefully I'll hear back soon. |
|
Sorry about the delay, but the CLA is signed and so this is good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partner to bazel-contrib/rules_nodejs#3535, applying that fix here as well.
The issue is that when calculating the output, it's overzealously removing the root_dir matches. I'm happy to change this to be whatever we think is clearest, because right now it is a bit magic-number-y.