feat: validate tsconfig outDir vs ts_project(out_dir)

aspect-build · Jan 7, 2025 · 9700b5e · 9700b5e
1 parent c63fb54
commit 9700b5e
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 0 deletions.
diff --git a/ts/private/ts_project_options_validator.js b/ts/private/ts_project_options_validator.js
@@ -102,6 +102,17 @@ function main(_a) {
             }
         }
     }
+    function check_out_dir() {
+        var attr = 'out_dir'
+        var optionVal = getTsOption('outDir')
+        var attrIsFalsyOrUndefined = attrs[attr] === false || attrs[attr] === '' || attrs[attr] === undefined
+        if (attrIsFalsyOrUndefined && optionVal !== undefined) {
+            throw new Error(
+                'When outDir is set in the tsconfig it must also be set in the ts_project' +
+                ' rule, so that the output directory is known to Bazel.'
+            )
+        }
+    }
     var jsxEmit =
         ((_b = {}),
         (_b[ts.JsxEmit.None] = 'none'),
@@ -163,6 +174,7 @@ function main(_a) {
     check('declaration')
     check('incremental')
     check('tsBuildInfoFile', 'ts_build_info_file')
+    check_out_dir()
     check_nocheck()
     check_preserve_jsx()
     if (failures.length > 0) {
@@ -201,6 +213,8 @@ function main(_a) {
             attrs.declaration +
             '\n// declaration_map:       ' +
             attrs.declaration_map +
+            '\n// out_dir:               ' +
+            attrs.out_dir +
             '\n// incremental:           ' +
             attrs.incremental +
             '\n// source_map:            ' +

diff --git a/ts/private/ts_validate_options.bzl b/ts/private/ts_validate_options.bzl
@@ -28,6 +28,7 @@ def _validate_action(ctx, tsconfig_inputs):
         allow_js = ctx.attr.allow_js,
         declaration = ctx.attr.declaration,
         declaration_map = ctx.attr.declaration_map,
+        out_dir = ctx.attr.out_dir,
         preserve_jsx = ctx.attr.preserve_jsx,
         composite = ctx.attr.composite,
         no_emit = ctx.attr.no_emit,