Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to aspect_rules_js to latest commit hash #63

Merged
merged 1 commit into from
Jul 29, 2022

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Jul 28, 2022

1.0.0-rc.2 breaks since we need the fix in aspect-build/rules_js#323

@gregmagolan gregmagolan requested a review from jbedard July 28, 2022 21:34
@gregmagolan gregmagolan requested a review from alexeagle July 28, 2022 21:44
@gregmagolan
Copy link
Member Author

@alexeagle Getting a

FATAL: aspect_rules_js[js_binary]: the node binary 'bazel-out/darwin-opt-exec-2B5CBBC6/bin/swc/cli.sh.runfiles/aspect_rules_swc/../node16_darwin_amd64/bin/nodejs/bin/node' not found in runfiles

failure on the upgrade to rules_js rc.2. I'm investigating as that I had changed the launcher script there recently.

@jbedard
Copy link
Member

jbedard commented Jul 28, 2022

I think that's the same error as in rules_ts and @thesayyn and I were hoping to pair with you on it Tuesday...

@gregmagolan gregmagolan changed the title chore: update to aspect_rules_js 1.0.0-rc.2 chore: update to aspect_rules_js latest commit hash Jul 29, 2022
@gregmagolan gregmagolan changed the title chore: update to aspect_rules_js latest commit hash chore: update to aspect_rules_js to latest commit hash Jul 29, 2022
@gregmagolan gregmagolan merged commit b5a31ef into main Jul 29, 2022
@alexeagle alexeagle deleted the rules_js_rc2 branch October 7, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants