Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: consider root dir for source maps paths #277

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

randrei-adobe
Copy link
Contributor

Fixes an issue where the root_dir was not considered when computing the paths in source maps. The issue is visible in the examples by checking the computed paths against the actual paths of the source files in the Bazel output directory.


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Rares Andrei seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@jbedard jbedard self-requested a review October 28, 2024 21:52
@jbedard jbedard enabled auto-merge (squash) October 28, 2024 22:27
@jbedard jbedard changed the title fix: Consider root dir for source maps paths fix: consider root dir for source maps paths Oct 28, 2024
@jbedard jbedard merged commit d781cdd into aspect-build:main Oct 28, 2024
10 of 11 checks passed
@randrei-adobe randrei-adobe deleted the randrei/fixSourceMaps branch October 29, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants