expose the raw swc rule as public API #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed when using it with the ts_project#transpiler attribute, as it wants to set js_outs rather than reuse the swc macro to do that.
alexeagle
force-pushed
the
rule_api
branch
3 times, most recently
from
95074c7 to
f9eff7f
Compare
kormide
reviewed
Dec 21, 2021
swc/private/swc.bzl
Outdated
Comment on lines
20
to
21
| "js_outs": attr.output_list(doc = "List of expected JavaScript output files"), | ||
| "map_outs": attr.output_list(doc = "List of expected source map output files"), |
There was a problem hiding this comment.
nit: other docs don't capitalize first letter
dymart
approved these changes
Dec 21, 2021
kormide
approved these changes
Dec 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed when it's called as the
transpilerof ats_project