Skip to content

Commit

Permalink
Revert "feat: transpiler function returns unused srcs (#116)"
Browse files Browse the repository at this point in the history
This reverts commit 137ce16.
  • Loading branch information
alexeagle authored Dec 2, 2022
1 parent 137ce16 commit 3a1f6be
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 15 deletions.
4 changes: 0 additions & 4 deletions docs/swc.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 0 additions & 7 deletions swc/defs.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ def swc(name, srcs = None, args = [], data = [], output_dir = False, swcrc = Non
swcrc: label of a configuration file for swc, see https://swc.rs/docs/configuration/swcrc
out_dir: base directory for output files relative to the output directory for this package
**kwargs: additional named parameters like tags or visibility
Returns:
subset of srcs which aren't transpiled by swc
"""
if srcs == None:
srcs = native.glob(["**/*.ts", "**/*.tsx"])
Expand Down Expand Up @@ -86,7 +83,3 @@ def swc(name, srcs = None, args = [], data = [], output_dir = False, swcrc = Non
out_dir = out_dir,
**kwargs
)

# Newer rules_ts versions make use of this return value.
# See https://github.com/aspect-build/rules_ts/blob/08f14d4ff792ca6fe091a009557642f7b0e20994/docs/transpiler.md#ts_projecttranspiler
return _swc_lib.calculate_unused_inputs(srcs)
4 changes: 0 additions & 4 deletions swc/private/swc.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -100,9 +100,6 @@ def _calculate_map_out(src, source_maps, out_dir = None):
def _calculate_map_outs(srcs, source_maps, out_dir = None):
return [f2 for f2 in [_calculate_map_out(f, source_maps, out_dir) for f in srcs] if f2]

def _calculate_unused_inputs(srcs):
return [s for s in srcs if not _is_supported_src(s)]

def _impl(ctx):
swcinfo = ctx.toolchains["@aspect_rules_swc//swc:toolchain_type"].swcinfo
env = {
Expand Down Expand Up @@ -241,5 +238,4 @@ swc = struct(
calculate_js_out = _calculate_js_out,
calculate_js_outs = _calculate_js_outs,
calculate_map_outs = _calculate_map_outs,
calculate_unused_inputs = _calculate_unused_inputs,
)

0 comments on commit 3a1f6be

Please sign in to comment.