Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(npm): invalid export of package/resolved.json #1855

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jul 20, 2024

The generated @npm//v61/BUILD.bazel had:

export_files(["v61/is-odd/resolved.json"])

Which should not have the v61/ because this is the v61/BUILD. The majority of use cases the lockfile is in the root and we don't see this problem.


Changes are visible to end-users: no

Test plan

  • New test cases added
  • Manual testing; please provide instructions so we can reproduce:

@jbedard jbedard requested review from gregmagolan and thesayyn July 20, 2024 00:36
@jbedard jbedard enabled auto-merge (squash) July 20, 2024 05:09
@jbedard jbedard merged commit 45c84b1 into aspect-build:main Jul 22, 2024
98 checks passed
@jbedard jbedard deleted the resolved-path branch July 22, 2024 23:23
jbedard added a commit to jbedard/rules_js that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants