Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pnpm): npm: aliases to self #1846

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jul 11, 2024

When a specifier uses npm: to reference itself the resolved version is just the raw version, where normally npm: specifiers result in actual-pkg@version.

Fix #1843


Changes are visible to end-users: no

Test plan

  • Covered by existing test cases
  • New test cases added

Copy link

aspect-workflows bot commented Jul 11, 2024

Test

All tests were cache hits

195 tests (100.0%) were fully cached saving 37s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 459ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 534ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.


Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 583ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 269ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 574ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

28 tests (100.0%) were fully cached saving 13s.


Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 6s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

10 tests (100.0%) were fully cached saving 6s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 464ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 460ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 229ms.


Buildifier      Format

@jbedard jbedard requested review from gregmagolan and thesayyn July 11, 2024 20:12
@jbedard jbedard force-pushed the 1843-self-npm-ref branch from c2863cc to b8c5d82 Compare July 11, 2024 20:18
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jbedard jbedard force-pushed the 1843-self-npm-ref branch from b8c5d82 to 4ca60b2 Compare July 11, 2024 20:23
@jbedard jbedard enabled auto-merge (squash) July 11, 2024 20:24
@jbedard jbedard merged commit 508d967 into aspect-build:main Jul 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: version in pnpm9 lockfile is incorrectly parsed
2 participants