Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixup snapshot tests after rebase #1688

Merged
merged 1 commit into from
Apr 29, 2024
Merged

chore: fixup snapshot tests after rebase #1688

merged 1 commit into from
Apr 29, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Apr 28, 2024 •
edited
Loading

No description provided.

@aspect-workflows Aspect Workflows
Copy link

aspect-workflows bot commented Apr 28, 2024 •
edited
Loading

Test

1 test target passed

Targets 
//js/private/test/image:checksum_test_test [k8-fastbuild] 109ms

Total test execution time was 109ms. 189 tests (99.5%) were fully cached saving 58s.

Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 428ms.

Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 704ms.

Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 5s.

Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 812ms.

Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.

Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.

Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.

Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 205ms.

Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.

Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 435ms.

Test

e2e/pnpm_lockfiles

All tests were cache hits

4 tests (100.0%) were fully cached saving 564ms.

Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 3s.

Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 2s.

Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 467ms.

Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 350ms.

Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 164ms.

Buildifier      Format

@gregmagolan gregmagolan force-pushed the fixup_after_rebases branch 2 times, most recently from 9eda303 to 5d0c837 Compare April 29, 2024 00:02
@gregmagolan gregmagolan force-pushed the fixup_after_rebases branch from 5d0c837 to 2a54739 Compare April 29, 2024 00:04
@gregmagolan gregmagolan merged commit f626492 into 2.x Apr 29, 2024
102 checks passed
@gregmagolan gregmagolan deleted the fixup_after_rebases branch April 29, 2024 00:07
gregmagolan added a commit that referenced this pull request Apr 29, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
5d69610
gregmagolan added a commit that referenced this pull request May 6, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
5d15c62
jbedard pushed a commit that referenced this pull request May 6, 2024
@gregmagolan @jbedard
chore: fixup snapshot tests after rebase (#1688)
935e6ea
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
8bb680a
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
6d384a7
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
f9c23d0
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
c7c13c2
gregmagolan added a commit that referenced this pull request May 7, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
9387454
jbedard pushed a commit that referenced this pull request May 8, 2024
@gregmagolan @jbedard
chore: fixup snapshot tests after rebase (#1688)
df58d50
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
128f92f
gregmagolan added a commit that referenced this pull request May 10, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
7a73e71
@gregmagolan gregmagolan mentioned this pull request May 10, 2024
Merged
gregmagolan added a commit that referenced this pull request May 13, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
6fbbb35
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 14, 2024
@gregmagolan @jbedard
chore: fixup snapshot tests after rebase (aspect-build#1688)
9338031
jbedard pushed a commit that referenced this pull request May 14, 2024
@gregmagolan @jbedard
chore: fixup snapshot tests after rebase (#1688)
92d7027
jbedard pushed a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@gregmagolan @jbedard
chore: fixup snapshot tests after rebase (aspect-build#1688)
e482e7e
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
f289a19
gregmagolan added a commit that referenced this pull request May 20, 2024
@gregmagolan
chore: fixup snapshot tests after rebase (#1688)
689405b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbedard jbedard jbedard approved these changes

@thesayyn thesayyn Awaiting requested review from thesayyn

@alexeagle alexeagle Awaiting requested review from alexeagle

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregmagolan @jbedard