Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set --test_tag_filters on cli and not via bazelrc #1678

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

gregmagolan
Copy link
Member

@gregmagolan gregmagolan commented Apr 23, 2024

--test_tag_filters are not additive so in order to set multiple tag filters from matrix settings we need to do some on the CLI

@gregmagolan gregmagolan requested a review from jbedard April 23, 2024 07:48
@gregmagolan gregmagolan enabled auto-merge (squash) April 23, 2024 07:48
Copy link

aspect-workflows bot commented Apr 23, 2024

Test

All tests were cache hits

211 tests (100.0%) were fully cached saving 43s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 1s.


Test

e2e/gyp_no_install_script

All tests were cache hits

3 tests (100.0%) were fully cached saving 930ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 5s.


Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 3s.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 3s.


Test

e2e/npm_translate_lock

All tests were cache hits

2 tests (100.0%) were fully cached saving 481ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

2 tests (100.0%) were fully cached saving 301ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 435ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 188ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 301ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 393ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 239ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 927ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

4 tests (100.0%) were fully cached saving 440ms.


Test

e2e/pnpm_workspace

All tests were cache hits

8 tests (100.0%) were fully cached saving 7s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

6 tests (100.0%) were fully cached saving 5s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 490ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 2s.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 229ms.


Buildifier      Format

@gregmagolan gregmagolan merged commit a98d182 into main Apr 23, 2024
5 of 102 checks passed
@gregmagolan gregmagolan deleted the fixup_test_tag_filters branch April 23, 2024 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants