-
-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: don't gather files from NpmPackageStoreInfo providers in gather_files_from_js_info #1663
Conversation
TestAll tests were cache hits 199 tests (100.0%) were fully cached saving 1m 1s. Teste2e/bzlmodAll tests were cache hits 4 tests (100.0%) were fully cached saving 1s. Teste2e/gyp_no_install_scriptAll tests were cache hits 2 tests (100.0%) were fully cached saving 2s. Teste2e/js_image_ociAll tests were cache hits 1 test (100.0%) was fully cached saving 5s. Teste2e/npm_link_packageAll tests were cache hits 2 tests (100.0%) were fully cached saving 857ms. Teste2e/npm_link_package-esmAll tests were cache hits 2 tests (100.0%) were fully cached saving 2s. Teste2e/npm_translate_lockAll tests were cache hits 1 test (100.0%) was fully cached saving 91ms. Teste2e/npm_translate_lock_emptyAll tests were cache hits 1 test (100.0%) was fully cached saving 91ms. Teste2e/npm_translate_lock_multiAll tests were cache hits 2 tests (100.0%) were fully cached saving 435ms. Teste2e/npm_translate_lock_partial_cloneAll tests were cache hits 1 test (100.0%) was fully cached saving 188ms. Teste2e/npm_translate_lock_subdir_patchBuildkite build #3231 is running... Teste2e/npm_translate_package_lockAll tests were cache hits 1 test (100.0%) was fully cached saving 393ms. Teste2e/npm_translate_yarn_lockAll tests were cache hits 1 test (100.0%) was fully cached saving 239ms. Teste2e/package_json_moduleAll tests were cache hits 1 test (100.0%) was fully cached saving 1s. Teste2e/pnpm_lockfilesWaiting for runner... Teste2e/pnpm_workspaceAll tests were cache hits 8 tests (100.0%) were fully cached saving 9s. Teste2e/pnpm_workspace_rerootedAll tests were cache hits 6 tests (100.0%) were fully cached saving 4s. Teste2e/rules_fooAll tests were cache hits 2 tests (100.0%) were fully cached saving 899ms. Teste2e/vendored_nodeAll tests were cache hits 1 test (100.0%) was fully cached saving 447ms. Buildifier Format |
3bfd482
to
c177d2e
Compare
c177d2e
to
0e267ad
Compare
c395f29
to
88826a2
Compare
…ther_files_from_js_info
88826a2
to
175a0fa
Compare
So we added the |
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (aspect-build#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (aspect-build#1663)
…ther_files_from_js_info (#1663)
…ther_files_from_js_info (#1663)
This was a bad pattern to pull from NpmPackageStoreInfo in the helper. Instead npm_package_store should just put its transitive files closure in DefaultInfo runfiles and also provide a JsInfo for when it is used directly in a js_run_binary or other js rules.