Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove js_image_layer bazel5 legacy symlink detection #1610

Merged
merged 1 commit into from
Apr 7, 2024
Merged

refactor: remove js_image_layer bazel5 legacy symlink detection #1610

merged 1 commit into from
Apr 7, 2024

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Apr 6, 2024 •
edited
Loading

Type of change

  • Refactor (a code change that neither fixes a bug or adds a new feature)

Test plan

  • Covered by existing test cases

@jbedard jbedard force-pushed the 2x-rm-symlink-detection branch from ee9a5cf to 6886a04 Compare April 6, 2024 22:42
@jbedard jbedard marked this pull request as ready for review April 7, 2024 00:29
@jbedard jbedard requested review from thesayyn and gregmagolan April 7, 2024 00:29
thesayyn
thesayyn reviewed Apr 7, 2024
View reviewed changes
Copy link
Member

@thesayyn thesayyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update rule impl as well

@jbedard jbedard force-pushed the 2x-rm-symlink-detection branch from 6886a04 to 48af645 Compare April 7, 2024 00:35
@jbedard
Copy link
Member Author

jbedard commented Apr 7, 2024

you need to update rule impl as well

Good point, thanks! (and updated...)

@jbedard jbedard force-pushed the 2x-rm-symlink-detection branch from 48af645 to 981c67e Compare April 7, 2024 01:27
gregmagolan
gregmagolan approved these changes Apr 7, 2024
View reviewed changes
Copy link
Member

@gregmagolan gregmagolan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jbedard jbedard merged commit caac704 into aspect-build:2.x Apr 7, 2024
91 checks passed
jbedard added a commit that referenced this pull request Apr 9, 2024
@jbedard
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
ce09b22
gregmagolan pushed a commit that referenced this pull request Apr 9, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
6f3e64a
gregmagolan pushed a commit that referenced this pull request Apr 13, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
cccbfbc
gregmagolan pushed a commit that referenced this pull request Apr 13, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
1b50769
gregmagolan pushed a commit that referenced this pull request Apr 15, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
c13f580
gregmagolan pushed a commit that referenced this pull request Apr 19, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
77d8541
jbedard added a commit that referenced this pull request Apr 19, 2024
@jbedard
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
684878f
gregmagolan pushed a commit that referenced this pull request Apr 20, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
3132410
gregmagolan pushed a commit that referenced this pull request Apr 21, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
6fbf704
gregmagolan pushed a commit that referenced this pull request Apr 21, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
759a3b4
gregmagolan pushed a commit that referenced this pull request Apr 22, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
3ecd172
gregmagolan pushed a commit that referenced this pull request Apr 23, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
2af9898
gregmagolan pushed a commit that referenced this pull request Apr 24, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
22814ec
gregmagolan pushed a commit that referenced this pull request Apr 26, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
02c0fb1
gregmagolan pushed a commit that referenced this pull request Apr 28, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
1a3bcad
gregmagolan pushed a commit that referenced this pull request Apr 28, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
13ccd5f
gregmagolan pushed a commit that referenced this pull request Apr 29, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
6ba8023
@gregmagolan gregmagolan mentioned this pull request Apr 29, 2024
Closed
21 tasks
gregmagolan pushed a commit that referenced this pull request May 6, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
dd707cf
jbedard added a commit that referenced this pull request May 6, 2024
@jbedard
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
7fae341
gregmagolan pushed a commit that referenced this pull request May 7, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
8ab58d4
gregmagolan pushed a commit that referenced this pull request May 7, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
9bfaaea
gregmagolan pushed a commit that referenced this pull request May 7, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
5254a78
jbedard added a commit that referenced this pull request May 8, 2024
@jbedard
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
7c0207e
gregmagolan pushed a commit that referenced this pull request May 10, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
28c4367
gregmagolan pushed a commit that referenced this pull request May 10, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
5abf1fb
@gregmagolan gregmagolan mentioned this pull request May 10, 2024
Merged
gregmagolan pushed a commit that referenced this pull request May 13, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
ce0d975
jbedard added a commit to jbedard/rules_js that referenced this pull request May 14, 2024
@jbedard
refactor: remove js_image_layer bazel5 legacy symlink detection (aspe…
3114d2c 
…ct-build#1610)
jbedard added a commit that referenced this pull request May 14, 2024
@jbedard
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
4edf206
jbedard added a commit to jbedard/rules_js that referenced this pull request May 16, 2024
@jbedard
refactor: remove js_image_layer bazel5 legacy symlink detection (aspe…
389d4c4 
…ct-build#1610)
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
037ac46
gregmagolan pushed a commit that referenced this pull request May 20, 2024
@jbedard @gregmagolan
refactor: remove js_image_layer bazel5 legacy symlink detection (#1610)
c4963a6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thesayyn thesayyn thesayyn left review comments

@gregmagolan gregmagolan gregmagolan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbedard @gregmagolan @thesayyn