Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove deprecated update_pnpm_lock_node_toolchain_prefix from npm_translate_lock #1574

Merged
merged 1 commit into from
Apr 2, 2024
Merged

refactor: remove deprecated update_pnpm_lock_node_toolchain_prefix from npm_translate_lock #1574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions npm/private/npm_translate_lock.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -555,9 +555,6 @@ def npm_translate_lock(
**kwargs: Internal use only
"""

# TODO(2.0): remove backward compat support for update_pnpm_lock_node_toolchain_prefix
update_pnpm_lock_node_toolchain_prefix = kwargs.pop("update_pnpm_lock_node_toolchain_prefix", None)

# TODO(2.0): move this to a new required rules_js_repositories() WORKSPACE function
if register_copy_directory_toolchains and not native.existing_rule("copy_directory_toolchains"):
_register_copy_directory_toolchains()
Expand Down Expand Up @@ -659,7 +656,7 @@ def npm_translate_lock(
data = data,
preupdate = preupdate,
quiet = quiet,
node_toolchain_prefix = update_pnpm_lock_node_toolchain_prefix if update_pnpm_lock_node_toolchain_prefix else node_toolchain_prefix,
node_toolchain_prefix = node_toolchain_prefix,
use_pnpm = use_pnpm,
yq_toolchain_prefix = yq_toolchain_prefix,
npm_package_target_name = npm_package_target_name,
Expand Down