Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make internal unresolved_symlinks_enabled attribute of js_binary mandatory #1571

Merged
merged 1 commit into from
Apr 2, 2024
Merged

refactor: make internal unresolved_symlinks_enabled attribute of js_binary mandatory #1571

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/js_binary.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions js/private/js_binary.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,8 +267,7 @@ _ATTRS = {
attribute based on a `config_setting` rule.
See /js/private/BUILD.bazel in rules_js for an example.
""",
# TODO(2.0): make this mandatory so that downstream binary rules that inherit these attributes are required to set it
gregmagolan marked this conversation as resolved.
Show resolved Hide resolved
mandatory = False,
mandatory = True,
),
gregmagolan marked this conversation as resolved.
Show resolved Hide resolved
"node_toolchain": attr.label(
doc = """The Node.js toolchain to use for this target.
Expand Down