Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unused warn_on_unqualified_tarball_url from npm_translate_lock #1568

Merged
merged 1 commit into from
Apr 2, 2024
Merged

refactor: remove unused warn_on_unqualified_tarball_url from npm_translate_lock #1568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/npm_translate_lock.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 0 additions & 5 deletions npm/private/npm_translate_lock.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,9 +194,6 @@ def npm_translate_lock(
use_starlark_yaml_parser = False,
# TODO(2.0): remove package_json
package_json = None,
# TODO(2.0): remove warn_on_unqualified_tarball_url
# buildifier: disable=unused-variable
warn_on_unqualified_tarball_url = None,
**kwargs):
"""Repository macro to generate starlark code from a lock file.
Expand Down Expand Up @@ -527,8 +524,6 @@ def npm_translate_lock(
Add all `package.json` files that are part of the workspace to `data` instead.
warn_on_unqualified_tarball_url: Deprecated. Will be removed in next major release.
npm_package_target_name: The name of linked `npm_package` targets. When `npm_package` targets are linked as pnpm workspace
packages, the name of the target must align with this value.
Expand Down