refactor: remove //js:enable_runfiles and use @aspect_bazel_lib//lib:…

…enable_runfiles instead (#1605)
aspect-build · Apr 19, 2024 · ff4097a · ff4097a
1 parent 5d05f99
commit ff4097a
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 12 deletions.
diff --git a/js/BUILD.bazel b/js/BUILD.bazel
@@ -8,12 +8,6 @@ exports_files(
     visibility = ["//docs:__pkg__"],
 )
 
-config_setting(
-    name = "enable_runfiles",
-    values = {"enable_runfiles": "true"},
-    visibility = ["//visibility:public"],
-)
-
 bzl_library(
     name = "defs",
     srcs = ["defs.bzl"],

diff --git a/js/defs.bzl b/js/defs.bzl
@@ -29,7 +29,7 @@ load(
 def js_binary(**kwargs):
     _js_binary(
         enable_runfiles = select({
-            Label("@aspect_rules_js//js:enable_runfiles"): True,
+            Label("@aspect_bazel_lib//lib:enable_runfiles"): True,
             "//conditions:default": False,
         }),
         **kwargs
@@ -38,7 +38,7 @@ def js_binary(**kwargs):
 def js_test(**kwargs):
     _js_test(
         enable_runfiles = select({
-            Label("@aspect_rules_js//js:enable_runfiles"): True,
+            Label("@aspect_bazel_lib//lib:enable_runfiles"): True,
             "//conditions:default": False,
         }),
         **kwargs

diff --git a/js/private/js_run_devserver.bzl b/js/private/js_run_devserver.bzl
@@ -263,7 +263,7 @@ def js_run_devserver(
     rule_to_execute(
         name = name,
         enable_runfiles = select({
-            "@aspect_rules_js//js:enable_runfiles": True,
+            "@aspect_bazel_lib//lib:enable_runfiles": True,
             "//conditions:default": False,
         }),
         entry_point = "@aspect_rules_js//js/private:js_devserver_entrypoint",

diff --git a/js/private/test/coverage/BUILD.bazel b/js/private/test/coverage/BUILD.bazel
@@ -24,7 +24,7 @@ coverage_fail_test(
     name = "fail",
     data = ["lib.js"],
     enable_runfiles = select({
-        "@aspect_rules_js//js:enable_runfiles": True,
+        "@aspect_bazel_lib//lib:enable_runfiles": True,
         "//conditions:default": False,
     }),
     entry_point = "lib.js",
@@ -52,7 +52,7 @@ coverage_pass_test(
     name = "pass",
     data = ["lib.js"],
     enable_runfiles = select({
-        "@aspect_rules_js//js:enable_runfiles": True,
+        "@aspect_bazel_lib//lib:enable_runfiles": True,
         "//conditions:default": False,
     }),
     entry_point = "lib.js",

diff --git a/js/private/test/create_launcher/custom_test.bzl b/js/private/test/create_launcher/custom_test.bzl
@@ -49,7 +49,7 @@ _custom_test = rule(
 def custom_test(**kwargs):
     _custom_test(
         enable_runfiles = select({
-            "//js:enable_runfiles": True,
+            "@aspect_bazel_lib//lib:enable_runfiles": True,
             "//conditions:default": False,
         }),
         **kwargs