refactor: make unresolved_symlinks_enabled attribute of js_binary man…

…datory
aspect-build · Apr 2, 2024 · 9aea8fb · 9aea8fb
1 parent 3b24f28
commit 9aea8fb
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/js/private/js_binary.bzl b/js/private/js_binary.bzl
@@ -267,8 +267,7 @@ _ATTRS = {
         attribute based on a `config_setting` rule.
         See /js/private/BUILD.bazel in rules_js for an example.
         """,
-        # TODO(2.0): make this mandatory so that downstream binary rules that inherit these attributes are required to set it
-        mandatory = False,
+        mandatory = True,
     ),
     "node_toolchain": attr.label(
         doc = """The Node.js toolchain to use for this target.